toolset issueshttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues2017-12-08T23:29:54+01:00https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/28Disabling console output, especially the progress bar2017-12-08T23:29:54+01:00Michaela Klauckklauck@depend.uni-saarland.deDisabling console output, especially the progress barAs far as the Modest people in Saarbrücken know, there is no way to disable the console output, especially the progress bar. For some purposes, like e.g. for debugging, but also for other applications where no statistics etc. are used, i...As far as the Modest people in Saarbrücken know, there is no way to disable the console output, especially the progress bar. For some purposes, like e.g. for debugging, but also for other applications where no statistics etc. are used, it would be great to have a flag or a parameter to enable/disable the output. More concrete this is sometimes necessary, because the progress bar can be interleaved by other outputs, which then are partially overwritten. In addition the progress bar causes crashes of the execution if the console window is resized/moved to another window during execution on linux.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/46Support for safety LTL fragment2018-04-11T16:08:06+02:00Arnd HartmannsSupport for safety LTL fragmentA subset of LTL can be decided with observer automata that do not make use of omega conditions like Büchi etc. Properties using this subset could be supported in all analysis tools by adding an automata transformation that adds such an o...A subset of LTL can be decided with observer automata that do not make use of omega conditions like Büchi etc. Properties using this subset could be supported in all analysis tools by adding an automata transformation that adds such an observer and simplifies the corresponding property to a reachability property.Sanny SchmittSanny Schmitthttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/45Support more than one initial state2018-03-12T13:38:26+01:00Michaela Klauckklauck@depend.uni-saarland.deSupport more than one initial stateModest does currently not support more than one initial state. This means that initial state restrictions using disjunctions or shrinking variables to a certain range are not allowed. Therefore this issue is in some sense related to #44....Modest does currently not support more than one initial state. This means that initial state restrictions using disjunctions or shrinking variables to a certain range are not allowed. Therefore this issue is in some sense related to #44.
A workaround would be to add a dummy initial state with tau transitions to all other real initial states. But since PRISM supports this feature, all JANI translations from such PRISM models will result in Jani files not directly (without a preprocessing step adding the dummy initial state) supported by Modest.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/43Licensing2018-03-26T17:08:55+02:00Michaela Klauckklauck@depend.uni-saarland.deLicensingBecause more and more students and other developers contribute to the Modest Toolset, we should set up a CLA and ask previous contributors to sign it retroactively. At the moment there is no concrete license for Modest, only that it is n...Because more and more students and other developers contribute to the Modest Toolset, we should set up a CLA and ask previous contributors to sign it retroactively. At the moment there is no concrete license for Modest, only that it is not open source. This issue should be discussed as soon as possible as long as all developers can be reached.Arnd HartmannsArnd Hartmannshttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/42Make interval arithmetic handle empty intervals gracefully2018-02-28T07:42:49+01:00Gereon Foxgfox@mpi-inf.mpg.deMake interval arithmetic handle empty intervals gracefullyRight now if you have two intervals `a` and `b` and one of them is empty, the operations `a + b` and `a - b` throw an `ArgumentOutOfRangeException.`. Making these operations simply return an empty interval instead would simplify calling ...Right now if you have two intervals `a` and `b` and one of them is empty, the operations `a + b` and `a - b` throw an `ArgumentOutOfRangeException.`. Making these operations simply return an empty interval instead would simplify calling code and actually fits the semantics of intervals well ("The sum of `a` and `b` is the interval of all values `x + y` for `x` from `a` and `y` from `b`").
I therefor suggest we make these operation return empty intervals in said case. I already tried to check if the exceptions are handled anywhere, which does not seem to be the case.
Any reason not to do it?Gereon Foxgfox@mpi-inf.mpg.deGereon Foxgfox@mpi-inf.mpg.dehttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/31String Representation of States in mcsta Scheduler2018-12-18T18:39:14+01:00Gregory StockString Representation of States in mcsta SchedulerI recently encounter a problem concerning the variable order in the states of a scheduler generated by `mcsta`.
The position of some variables in different schedulers for the "same" model (the structure is identical, only some initial va...I recently encounter a problem concerning the variable order in the states of a scheduler generated by `mcsta`.
The position of some variables in different schedulers for the "same" model (the structure is identical, only some initial variable/array values change) vary.
Context:
I use `modes` to simulate a modest model according to the `mcsta` scheduler in order to receive the optimal trace implicitely calculated by the model checker.
I currently rely on the position of the variables because otherwise I cannot distinguish between the `location` of all instances of the same process given that they all have the same name, e.g. `Experiment.location`.
In the previous model version, only the position of the global clock `gc` deterministically changed between the representation in the scheduler and the internal representation in `modes`[^1] / order in the output trace.
This allowed for a simple fix that deterministically moved the affected entries to their correct place.
This is yet not possible anymore as not even the order *within the schedulers* is predictable.
Example (first entry of the two schedulers):
```
+ State: (AttitudeControl.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Battery.location = 0, Sun.location = 0, Main.location = 0, GlobalInvariant.location = 0, GlobalSync.location = 0, a = 1, ratio = 0, AttitudeControl.a_dst = 0, gc = 0, new_time = 0, AttitudeControl.slewingEnd_time = 0, Battery.old_time = 0, ac_lock = False, slewing = False, insolation = False, Sun.updateAfterInsolationEnd = False, cost = 0, l = 134784000, sun_c = 0, Battery.r = 0, c = [0, 0, 0, 0, 0, 0, 0], nee = [0, 0, 0, 0, 0, 0, 0], pa = [False, False, False, False, False, False, False])
|============================================================================================================================================================================================================================|
+ State: (AttitudeControl.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Battery.location = 0, Sun.location = 0, Main.location = 0, GlobalInvariant.location = 0, GlobalSync.location = 0, a = 1, ratio = 0, AttitudeControl.a_dst = 0, ac_lock = False, slewing = False, insolation = False, Sun.updateAfterInsolationEnd = False, gc = 0, cost = 0, l = 134784000, new_time = 0, sun_c = 0, AttitudeControl.slewingEnd_time = 0, Battery.r = 0, Battery.old_time = 0, c = [0, 0, 0, 0, 0, 0, 0], nee = [0, 0, 0, 0, 0, 0, 0], pa = [False, False, False, False, False, False, False])
```
How is the variable order in the scheduler states determined? And is it possible to keep it fixed for the same model (only with different variable assignments) or even to ensure the same order within `mcsta`'s schedulers and `modes`' traces?
[^1]: for example the `toString()` of `ref T currentState` in `Simulation/Runs/STASimulationRun.cs`https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/25scheduling transitions, not actions2018-01-03T11:47:08+01:00Holger Hermannsscheduling transitions, not actionsIn order to avoid that a scheduler (as exported currently from mcsta) may induce nondeterminism (since it currently maps to actions), it appears more handy to instead map to pairs of action and target distribution, so as to enable the re...In order to avoid that a scheduler (as exported currently from mcsta) may induce nondeterminism (since it currently maps to actions), it appears more handy to instead map to pairs of action and target distribution, so as to enable the reconstruction of the exact transition taken.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/16Make automata modifiable2018-02-28T15:28:42+01:00Michaela Klauckklauck@depend.uni-saarland.deMake automata modifiableAt the moment you can only create an automaton from which you know already everything, i.e. all locations, edges, ... It would be nice to be able to construct an automaton on the fly by adding locations and edges one after another.
Even ...At the moment you can only create an automaton from which you know already everything, i.e. all locations, edges, ... It would be nice to be able to construct an automaton on the fly by adding locations and edges one after another.
Even better: Be able to modify the automaton as you like, i.e. allow to delete parts of it and check its consistency directly.Sanny SchmittSanny Schmitthttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/102Setting cycle-bound to 0 in modes leads to run length being exceeded immediately2023-02-02T19:21:29+01:00Arnd HartmannsSetting cycle-bound to 0 in modes leads to run length being exceeded immediately...whereas it should lead to unbounded cycle detection....whereas it should lead to unbounded cycle detection.Arnd HartmannsArnd Hartmannshttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/101Re-enabling location variables and optimisation in Simulation may affect DSMC...2023-02-04T10:08:57+01:00Arnd HartmannsRe-enabling location variables and optimisation in Simulation may affect DSMC/oraclesIn Simulation/SimulationAnalysisEngine.cs, commit b419eb6adcad4bca29871cb122ca72e876f3372a (which merged Michaela's work on resolving nondeterminism via neural networks (DSMC) or external oracles in Simulation) commented out two model tr...In Simulation/SimulationAnalysisEngine.cs, commit b419eb6adcad4bca29871cb122ca72e876f3372a (which merged Michaela's work on resolving nondeterminism via neural networks (DSMC) or external oracles in Simulation) commented out two model transformations:
`//new Guid("14323163-B374-4AEC-976A-49EBDFE9D458"), // detect and expand location variables //commented out to preserve automata edge order from JANI file`
and
`//nstaOptimizationGuid = new Guid("10D9051D-FA26-468F-B138-60F26C729037"), // optimize automata/network //commented out to preserve automata edge order from JANI file`
The former is important for performance, and the latter is important to replace complex constant expressions with their actual numeric values. Especially commenting out the latter is currently leading to errors on QVBS models.
I am now re-enabling these two transformations, but this may have an impact on DSMC/oracles. I ask those who maintain the DSMC/oracle functionality to please review the impact and adapt the DSMC/oracle code accordingly. The first transformation (location variables) could be conditionally disabled when using DSMC/oracles, but the second one (optimisation) is necessary to make several models compile in the first place.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/100Mec in Interval Iteration2022-09-20T15:11:33+02:00Ivan HopMec in Interval IterationUsing the following command.
check erlang.jani -E K=5000,R=100,TIME_BOUND=50 --alg IntervalIteration --props TminReach
The statespace of interval iterations contains a mec.
State with index 8 goes to state with index 11. The state wit...Using the following command.
check erlang.jani -E K=5000,R=100,TIME_BOUND=50 --alg IntervalIteration --props TminReach
The statespace of interval iterations contains a mec.
State with index 8 goes to state with index 11. The state with index 11 goes to state with index 8. All with one branch and probability one.
I noticed that avoid was null.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/99wlan-large identified as an STA model, PTA expected2022-06-20T17:59:15+02:00Valentijn Holwlan-large identified as an STA model, PTA expectedThe [wlan-large](https://qcomp.org/benchmarks/#wlan-large) benchmark is listed as a PTA model in QComp.
One would expect MCSTA to identify it as such, however it's identified as a STA instead. See output:
```
wlan-large.jani:model: inf...The [wlan-large](https://qcomp.org/benchmarks/#wlan-large) benchmark is listed as a PTA model in QComp.
One would expect MCSTA to identify it as such, however it's identified as a STA instead. See output:
```
wlan-large.jani:model: info: wlan-large is an STA model.
wlan-large.jani: info: Need 16 bytes per state.
...
```https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/98Assertion fail when executing mosta2022-03-25T15:02:29+01:00Joost SessinkAssertion fail when executing mostaIf `./modest mosta` is executed using the debug version of Modest, the assertion at line 566 of `CommandLineParser.cs` fails.If `./modest mosta` is executed using the debug version of Modest, the assertion at line 566 of `CommandLineParser.cs` fails.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/95Missing DisplayNames in DotExporter and PythonExporter2021-03-29T10:37:48+02:00Peter SmitMissing DisplayNames in DotExporter and PythonExporterBoth the Dot- and PythonExporter's parameters classes are missing the DisplayName attribute on their properties.Both the Dot- and PythonExporter's parameters classes are missing the DisplayName attribute on their properties.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/94mosta doesn't check if a dotOutputFile is specified when validating the param...2021-03-23T11:23:18+01:00Alexander Stekelenburgmosta doesn't check if a dotOutputFile is specified when validating the parametersCurrently mosta checks whether a dotFormat is specified without an output file which results in an error. It doesn't perform the same check for the dotOutputFile which is also required for the tool to execute without errors. When invoked...Currently mosta checks whether a dotFormat is specified without an output file which results in an error. It doesn't perform the same check for the dotOutputFile which is also required for the tool to execute without errors. When invoked using the command line this isn't a problem because it is impossible to specify a dot format without also providing a dotOutputFile. However when invoking the tool programmatically it is possible to specify these parameters separately.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/93mosta fails when any experiment parameters are provided2021-03-23T11:13:30+01:00Alexander Stekelenburgmosta fails when any experiment parameters are providedWhen any experiment parameters are provided to the mosta tool it will complain that no value is specified for one of the model parameters. This happens because the ExperimentInstantiationConversion is added to the TransformationGraph but...When any experiment parameters are provided to the mosta tool it will complain that no value is specified for one of the model parameters. This happens because the ExperimentInstantiationConversion is added to the TransformationGraph but the parameters are not passed to it. This is not an issue when no experiment parameters are given because in that case the ExperimentInstantiationConversion won't be added to the TransformationGraph.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/91Default values for constants2020-11-25T19:27:17+01:00Arnd HartmannsDefault values for constantsCurrently, a constant in Modest and JANI either has a value assigned in the model, or it is open - then a value has to be specified on the command line for all tools in the Modest Toolset (or one could use a parametric analysis with e.g....Currently, a constant in Modest and JANI either has a value assigned in the model, or it is open - then a value has to be specified on the command line for all tools in the Modest Toolset (or one could use a parametric analysis with e.g. Storm). It would be convenient to be able to define a "default value" for (some) constants in a model, so that they take this value _unless_ one is specified on the command line. This would be an extension to both Modest and JANI.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/90ArgumentException on empty palt in Modest2020-10-16T16:15:06+02:00Arnd HartmannsArgumentException on empty palt in ModestThe following Modest code causes the tools to crash with an ArgumentException due to the empty `palt` construct:
```
property p = Pmin(<> (i > 10));
int i = 0;
process increment() {
{= i++ =};
palt {}
}
increment()
```
(Repor...The following Modest code causes the tools to crash with an ArgumentException due to the empty `palt` construct:
```
property p = Pmin(<> (i > 10));
int i = 0;
process increment() {
{= i++ =};
palt {}
}
increment()
```
(Reported by Gerlof Bouma.)https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/86Intermediate Probabilities Completely Fill Console2019-07-04T15:06:48+02:00Hans van der LaanIntermediate Probabilities Completely Fill Console**Problem:**
When calculating the 'P_MWinMax` property from 'bitcoin-attack.modest', the command line interface completely fills up with all 10.000 intermediate probabilities. We probably do not want to show all intermediate probabiliti...**Problem:**
When calculating the 'P_MWinMax` property from 'bitcoin-attack.modest', the command line interface completely fills up with all 10.000 intermediate probabilities. We probably do not want to show all intermediate probabilities when the user does not specifically ask for this.
An idea could print the first and last 100 probabilities, with a message accompanying the output stating that to get all intermediate probabilities the '-D' parameter should be added.
**Property:**
P_MWinMax = Pmax(<>[S(round)<=10000] (m_len >= CD && m_diff > 0)); the following property completely fills up
**Output:**
```
[...]
(3022, 0.288204053592764), (3023, 0.288284334303679), (3024, 0.288364605960044),
(3025, 0.288444868562878), (3026, 0.288525122113205), (3027, 0.288605366612044),
(3028, 0.288685602060416), (3029, 0.288765828459343), (3030, 0.288846045809844),
(3031, 0.288926254112941), (3032, 0.289006453369653), (3033, 0.289086643581002),
[...]
(9993, 0.675750001988019), (9994, 0.675786572890798), (9995, 0.675823139668887),
(9996, 0.67585970232275), (9997, 0.675896260852853), (9998, 0.67593281525966),
(9999, 0.675969365543638), (10000, 0.67600591170525)
}
Time: 0.3 s
+ Value iteration
Final error: 0
Iterations: 29996
Time: 0.2 s
PS C:\Users\Gebruiker\Documents\Werk\Modest\GitLab\toolset\Binaries\Release>
```https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/85modes: RES: ad hoc specification of threshold levels and splitting2019-06-11T19:05:26+02:00Carlos Estebanmodes: RES: ad hoc specification of threshold levels and splittingIn the modes commands for rare event simulation, make --levels accept a string of pairs "t1,s1 t2,s2 ... tn,sn" (in whatever syntax is convenient).
All pairs should be numbers: "ti,si" means that the i-th threshold used for RES is set at...In the modes commands for rare event simulation, make --levels accept a string of pairs "t1,s1 t2,s2 ... tn,sn" (in whatever syntax is convenient).
All pairs should be numbers: "ti,si" means that the i-th threshold used for RES is set at importance value "ti," and that the splitting to perform there is "si."Arnd HartmannsArnd Hartmanns