toolset issueshttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues2017-08-03T11:30:50+02:00https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/9declare a const array2017-08-03T11:30:50+02:00Gregory Stockdeclare a const arrayModest currently does not allow an array with a `const` / readonly modifier:
`> error: Constants cannot be of composite type.`
Background:
I have a model with very large `int`-arrays containing only constants needed for computation....Modest currently does not allow an array with a `const` / readonly modifier:
`> error: Constants cannot be of composite type.`
Background:
I have a model with very large `int`-arrays containing only constants needed for computation. Because I cannot declare them as `const`:
- `mcsta` writes them in every state of the scheduler gererated with the new `--scheduler` flag,
- `modes` writes them in my traces,
- `mosta` shows them in the global variables section (practically rendering the output useless because `dot` cannot handle this).https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/12Committed Locations2017-11-15T20:12:17+01:00Gregory StockCommitted LocationsUppaal has a feature called "*committed locations*".
The [Uppaal Web Help](http://www.it.uu.se/research/group/darts/uppaal/help.php?file=System_Descriptions/Locations.shtml) describes it as follows:
> Like urgent locations, committed l...Uppaal has a feature called "*committed locations*".
The [Uppaal Web Help](http://www.it.uu.se/research/group/darts/uppaal/help.php?file=System_Descriptions/Locations.shtml) describes it as follows:
> Like urgent locations, committed locations freeze time. Furthermore, if any process is in a committed location, the next transition must involve an edge from one of the committed locations.
This has the potential of reducing the state space a lot.
For example if we have five locations where each has an enabled (and urgent) transition.
- if _none_ of them are committed, we have `5! = 120` distinct sequences
- if _one_ location is committed, we have `1! * 4! = 24` distinct sequences
- if _two_ locations are committed, we have `2! * 3! = 12` distinct sequenceshttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/14Infrastructure for integration tests2018-03-01T14:09:20+01:00Gereon Foxgfox@mpi-inf.mpg.deInfrastructure for integration testsIn order to avoid regressions, Modest needs a suite of integration tests.
These tests should consist in a collection of JANI samples that are fed to the Model Checker and analysed by it, the outcome of which is compared to an expected o...In order to avoid regressions, Modest needs a suite of integration tests.
These tests should consist in a collection of JANI samples that are fed to the Model Checker and analysed by it, the outcome of which is compared to an expected outcome. In addition, performance regressions are to be detected.
Not only do we want to use this test suite in our development workflow, but also do we want to ship it as part of the Modest package, such that users can run the test suite on their own machine (which is useful e.g. to assess Modest performance under different hardware configurations).https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/16Make automata modifiable2018-02-28T15:28:42+01:00Michaela Klauckklauck@depend.uni-saarland.deMake automata modifiableAt the moment you can only create an automaton from which you know already everything, i.e. all locations, edges, ... It would be nice to be able to construct an automaton on the fly by adding locations and edges one after another.
Even ...At the moment you can only create an automaton from which you know already everything, i.e. all locations, edges, ... It would be nice to be able to construct an automaton on the fly by adding locations and edges one after another.
Even better: Be able to modify the automaton as you like, i.e. allow to delete parts of it and check its consistency directly.Sanny SchmittSanny Schmitthttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/17PRISM input and output support2019-02-26T13:16:15+01:00Arnd HartmannsPRISM input and output supportImplement support for the PRISM language (http://www.prismmodelchecker.org/manual/ThePRISMLanguage/Introduction) as an input and output formalism (i.e. lexer and parser for PRISM code, conversion from PRISM models to automata models, con...Implement support for the PRISM language (http://www.prismmodelchecker.org/manual/ThePRISMLanguage/Introduction) as an input and output formalism (i.e. lexer and parser for PRISM code, conversion from PRISM models to automata models, conversion from automata models to PRISM models, and formatting of PRISM models back to PRISM code).Sanny SchmittSanny Schmitthttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/18Smart sampling2017-11-15T14:52:39+01:00Arnd HartmannsSmart samplingImplement support for the "smart sampling" approach of Sedwards et al. (https://doi.org/10.1007/s10009-015-0383-0) in lightweight scheduler sampling for simulation of nondeterministic models. This should be both for reachability probabil...Implement support for the "smart sampling" approach of Sedwards et al. (https://doi.org/10.1007/s10009-015-0383-0) in lightweight scheduler sampling for simulation of nondeterministic models. This should be both for reachability probabilities as described in the original paper, plus a variant for expected-reward properties.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/19Simulation of steady-state properties2017-11-15T14:49:39+01:00Arnd HartmannsSimulation of steady-state propertiesThe simulator (modes tool, Simulation project) currently only handles transient properties: reachability probabilities and expected rewards. We need to add support for steady-state properties (the S operator in CSL), both for classic Mon...The simulator (modes tool, Simulation project) currently only handles transient properties: reachability probabilities and expected rewards. We need to add support for steady-state properties (the S operator in CSL), both for classic Monte Carlo simulation as well as for rare event simulation.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/21Modest language guide2017-11-15T14:59:19+01:00Arnd HartmannsModest language guideCreate a Modest language guide for the modestchecker.net website, similar to the documentation of the PRISM language at http://www.prismmodelchecker.org/manual/ThePRISMLanguage/Introduction.Create a Modest language guide for the modestchecker.net website, similar to the documentation of the PRISM language at http://www.prismmodelchecker.org/manual/ThePRISMLanguage/Introduction.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/22Use properties instead of fields for the state struct in compiled exploration2018-03-02T15:58:55+01:00Arnd HartmannsUse properties instead of fields for the state struct in compiled explorationCurrently, the locations and state variables of a model are compiled as fields into the state struct type in compiled exploration (in the Exploration project). This is inflexible since the way that values are stored cannot be changed ind...Currently, the locations and state variables of a model are compiled as fields into the state struct type in compiled exploration (in the Exploration project). This is inflexible since the way that values are stored cannot be changed independently of how the values are accessed. We should instead implement properties for the fields and only access (get and set) them via these properties. As a second step, this will allow more advanced storage, e.g. bit-packing multiple state variables into a single (short, int, long etc.) field of the struct.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/24Assignments native2018-06-21T17:40:28+02:00Holger HermannsAssignments nativeAt the end of Sec 6 of the [2006 Modest paper](http://www-i2.informatik.rwth-aachen.de/pub/index.php?type=download&pub_id=220) some abbreviations are defined.
It seems (at least) this one is not supported in the current version.
> I...At the end of Sec 6 of the [2006 Modest paper](http://www-i2.informatik.rwth-aachen.de/pub/index.php?type=download&pub_id=220) some abbreviations are defined.
It seems (at least) this one is not supported in the current version.
> In a similar line, conventional like `y := 3;` are to be read as `{= y:=3 =};`
It would be good to have that built in. The intention is that standard sequential programming (including also while/for etc) have native support in Modest (albeit at the price of inducing many internal transitions, which can be optimised away by good static analysis/compilation).Gereon Foxgfox@mpi-inf.mpg.deGereon Foxgfox@mpi-inf.mpg.dehttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/25scheduling transitions, not actions2018-01-03T11:47:08+01:00Holger Hermannsscheduling transitions, not actionsIn order to avoid that a scheduler (as exported currently from mcsta) may induce nondeterminism (since it currently maps to actions), it appears more handy to instead map to pairs of action and target distribution, so as to enable the re...In order to avoid that a scheduler (as exported currently from mcsta) may induce nondeterminism (since it currently maps to actions), it appears more handy to instead map to pairs of action and target distribution, so as to enable the reconstruction of the exact transition taken.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/28Disabling console output, especially the progress bar2017-12-08T23:29:54+01:00Michaela Klauckklauck@depend.uni-saarland.deDisabling console output, especially the progress barAs far as the Modest people in Saarbrücken know, there is no way to disable the console output, especially the progress bar. For some purposes, like e.g. for debugging, but also for other applications where no statistics etc. are used, i...As far as the Modest people in Saarbrücken know, there is no way to disable the console output, especially the progress bar. For some purposes, like e.g. for debugging, but also for other applications where no statistics etc. are used, it would be great to have a flag or a parameter to enable/disable the output. More concrete this is sometimes necessary, because the progress bar can be interleaved by other outputs, which then are partially overwritten. In addition the progress bar causes crashes of the execution if the console window is resized/moved to another window during execution on linux.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/31String Representation of States in mcsta Scheduler2018-12-18T18:39:14+01:00Gregory StockString Representation of States in mcsta SchedulerI recently encounter a problem concerning the variable order in the states of a scheduler generated by `mcsta`.
The position of some variables in different schedulers for the "same" model (the structure is identical, only some initial va...I recently encounter a problem concerning the variable order in the states of a scheduler generated by `mcsta`.
The position of some variables in different schedulers for the "same" model (the structure is identical, only some initial variable/array values change) vary.
Context:
I use `modes` to simulate a modest model according to the `mcsta` scheduler in order to receive the optimal trace implicitely calculated by the model checker.
I currently rely on the position of the variables because otherwise I cannot distinguish between the `location` of all instances of the same process given that they all have the same name, e.g. `Experiment.location`.
In the previous model version, only the position of the global clock `gc` deterministically changed between the representation in the scheduler and the internal representation in `modes`[^1] / order in the output trace.
This allowed for a simple fix that deterministically moved the affected entries to their correct place.
This is yet not possible anymore as not even the order *within the schedulers* is predictable.
Example (first entry of the two schedulers):
```
+ State: (AttitudeControl.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Battery.location = 0, Sun.location = 0, Main.location = 0, GlobalInvariant.location = 0, GlobalSync.location = 0, a = 1, ratio = 0, AttitudeControl.a_dst = 0, gc = 0, new_time = 0, AttitudeControl.slewingEnd_time = 0, Battery.old_time = 0, ac_lock = False, slewing = False, insolation = False, Sun.updateAfterInsolationEnd = False, cost = 0, l = 134784000, sun_c = 0, Battery.r = 0, c = [0, 0, 0, 0, 0, 0, 0], nee = [0, 0, 0, 0, 0, 0, 0], pa = [False, False, False, False, False, False, False])
|============================================================================================================================================================================================================================|
+ State: (AttitudeControl.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Experiment.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Exp_Provider.location = 0, Battery.location = 0, Sun.location = 0, Main.location = 0, GlobalInvariant.location = 0, GlobalSync.location = 0, a = 1, ratio = 0, AttitudeControl.a_dst = 0, ac_lock = False, slewing = False, insolation = False, Sun.updateAfterInsolationEnd = False, gc = 0, cost = 0, l = 134784000, new_time = 0, sun_c = 0, AttitudeControl.slewingEnd_time = 0, Battery.r = 0, Battery.old_time = 0, c = [0, 0, 0, 0, 0, 0, 0], nee = [0, 0, 0, 0, 0, 0, 0], pa = [False, False, False, False, False, False, False])
```
How is the variable order in the scheduler states determined? And is it possible to keep it fixed for the same model (only with different variable assignments) or even to ensure the same order within `mcsta`'s schedulers and `modes`' traces?
[^1]: for example the `toString()` of `ref T currentState` in `Simulation/Runs/STASimulationRun.cs`https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/41Move code formatting rules to solution / project files2018-03-07T12:07:19+01:00Felix FreibergerMove code formatting rules to solution / project filesAs discussed in the meeting, we want to align the coding guidelines with Visual Studio defaults and settings stored within the solution or project files.
Steps needed for this:
* [x] investigate how and which settings can be configure...As discussed in the meeting, we want to align the coding guidelines with Visual Studio defaults and settings stored within the solution or project files.
Steps needed for this:
* [x] investigate how and which settings can be configured for the project (@fefrei)
* [ ] make appropriate adjustments to the coding guidelines (@gfox, @ahartmanns)
* [ ] apply the adjusted guidelines to the projectGereon Foxgfox@mpi-inf.mpg.deGereon Foxgfox@mpi-inf.mpg.dehttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/42Make interval arithmetic handle empty intervals gracefully2018-02-28T07:42:49+01:00Gereon Foxgfox@mpi-inf.mpg.deMake interval arithmetic handle empty intervals gracefullyRight now if you have two intervals `a` and `b` and one of them is empty, the operations `a + b` and `a - b` throw an `ArgumentOutOfRangeException.`. Making these operations simply return an empty interval instead would simplify calling ...Right now if you have two intervals `a` and `b` and one of them is empty, the operations `a + b` and `a - b` throw an `ArgumentOutOfRangeException.`. Making these operations simply return an empty interval instead would simplify calling code and actually fits the semantics of intervals well ("The sum of `a` and `b` is the interval of all values `x + y` for `x` from `a` and `y` from `b`").
I therefor suggest we make these operation return empty intervals in said case. I already tried to check if the exceptions are handled anywhere, which does not seem to be the case.
Any reason not to do it?Gereon Foxgfox@mpi-inf.mpg.deGereon Foxgfox@mpi-inf.mpg.dehttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/43Licensing2018-03-26T17:08:55+02:00Michaela Klauckklauck@depend.uni-saarland.deLicensingBecause more and more students and other developers contribute to the Modest Toolset, we should set up a CLA and ask previous contributors to sign it retroactively. At the moment there is no concrete license for Modest, only that it is n...Because more and more students and other developers contribute to the Modest Toolset, we should set up a CLA and ask previous contributors to sign it retroactively. At the moment there is no concrete license for Modest, only that it is not open source. This issue should be discussed as soon as possible as long as all developers can be reached.Arnd HartmannsArnd Hartmannshttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/44Support complex initial state specifications2018-03-12T10:12:27+01:00Michaela Klauckklauck@depend.uni-saarland.deSupport complex initial state specificationsWhen restricting the initial state using an arithmetic expression (over global variables `q1, q2, q3` in this case), the error message:
> error: Complex initial states specifications are not yet supported.
is thrown.
It would be nice ...When restricting the initial state using an arithmetic expression (over global variables `q1, q2, q3` in this case), the error message:
> error: Complex initial states specifications are not yet supported.
is thrown.
It would be nice to extend the range of supported expressions because in e.g. PRISM case studies they are used very often.
` "restrict-initial":{
"exp":{
"op":"≥",
"left":{
"op":"+",
"left":{
"op":"+",
"left":"q1",
"right":"q2"
},
"right":"q3"
},
"right":1
}
},`
The currently supported syntax for initial state restrictions is checked in `DissectInitialStatesRestriction()` in `AutomataNetwork.cs`. And the error message is thrown in ` CreateSetInitialStateAndTransients()` in `CompiledAutomaton.cs`https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/45Support more than one initial state2018-03-12T13:38:26+01:00Michaela Klauckklauck@depend.uni-saarland.deSupport more than one initial stateModest does currently not support more than one initial state. This means that initial state restrictions using disjunctions or shrinking variables to a certain range are not allowed. Therefore this issue is in some sense related to #44....Modest does currently not support more than one initial state. This means that initial state restrictions using disjunctions or shrinking variables to a certain range are not allowed. Therefore this issue is in some sense related to #44.
A workaround would be to add a dummy initial state with tau transitions to all other real initial states. But since PRISM supports this feature, all JANI translations from such PRISM models will result in Jani files not directly (without a preprocessing step adding the dummy initial state) supported by Modest.https://dgit.cs.uni-saarland.de/modest/toolset/-/issues/46Support for safety LTL fragment2018-04-11T16:08:06+02:00Arnd HartmannsSupport for safety LTL fragmentA subset of LTL can be decided with observer automata that do not make use of omega conditions like Büchi etc. Properties using this subset could be supported in all analysis tools by adding an automata transformation that adds such an o...A subset of LTL can be decided with observer automata that do not make use of omega conditions like Büchi etc. Properties using this subset could be supported in all analysis tools by adding an automata transformation that adds such an observer and simplifies the corresponding property to a reachability property.Sanny SchmittSanny Schmitthttps://dgit.cs.uni-saarland.de/modest/toolset/-/issues/49Support for expected rate rewards in Markov automata model checking2018-06-16T00:57:54+02:00Arnd HartmannsSupport for expected rate rewards in Markov automata model checkingMarkov automata model checking in the ModelChecking project is currently only implemented for unbounded reachability and expected transition reward properties.
Task: Implement support for unbounded expected rate reward properties. I fir...Markov automata model checking in the ModelChecking project is currently only implemented for unbounded reachability and expected transition reward properties.
Task: Implement support for unbounded expected rate reward properties. I first thought this can be done symbolically (i.e. on the automata network level), but due to guards and maximal progress disabling Markovian transitions, it may rather need to be integrated into state space exploration.Arnd HartmannsArnd Hartmanns