Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • C concurrent-programming-web
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pseucopseuco
  • concurrent-programming-web
  • Merge requests
  • !36

Implement New File page

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dominic requested to merge react-newfile into react Jan 10, 2022
  • Overview 7
  • Commits 7
  • Pipelines 4
  • Changes 6

There is not too much to say. This MR implements the missing /new/{fileType} pages in React.

As intended, the client stores the templates locally and can (automatically and on demand) query templates from the API endpoint.

Issues:

  • Since the server is providing the template descriptions as HTML string, the current implementation relies on using React's dangerouslySetInnerHTML feature which is discouraged and a security risk. Particularly, tags will not prevent the default event for their behavior and thus, when clicked, click their DOM parent as well. When clicking the highlighted link in the attached picture, the user will create a file from the template and then be redirected to the link's target page. image
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: react-newfile