Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • P pseuco-shared-components
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pseucopseuco
  • pseuco-shared-components
  • Merge requests
  • !2

Fix pseuCoUrlFileEncoders only supporting files whose contents are strings

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Dominic Zimmer requested to merge fix-url-encoders into master Jul 06, 2021
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 1

The RemoteFile type was too restrictive to be correct. I changed it locally, only in util/pseuCoUrlFileEncoder.ts, oblivious if this is a breaking change.

Additionally, when parsing, we need to be aware if we are handling a textfile (lts, ccs) or an object. In the latter case, we need to parse the 'text' at hand yet again.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-url-encoders